Error when applying patch that removes submodule

[marcosdiazr]

Reproduction steps

on any existing repo that contains a submodule generate a diff that removes it:

$ git rm <submodule name>
$ git diff --staged > remove-submodule.patch

(I used git 2.25.1)
my generated patch looks like this:

diff --git a/.gitmodules b/.gitmodules
index 1b59123..e69de29 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,3 +0,0 @@
-[submodule "submodule"]
-	path = submodule
-	url = ../submodule
diff --git a/submodule b/submodule
deleted file mode 160000
index xxxxx..0000000
--- a/fus-modules
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit xxxxxxxxxxxxxxxxxxxxxxxxxxx

And when running this small program that uses libgit2:
test.c.txt
built using
gcc test.c -lgit2 -L <path to libgit2>/libgit2/build/ -Wall -pedantic -I <path to libgit2>/libgit2/include/
And run like this:
LD_LIBRARY_PATH=<path to libgit2>/libgit2/build/ ./a.out <Path to repo> <path to patch file>

Expected behavior

It successfully applies the change

Actual behavior

Error applying patch: -1 no error

I checked also modifying the submodule and it fails too

Version of libgit2 (release number or SHA1)

1.3.0 and main ( d74d491 )

Operating system(s) tested

Linux (Ubuntu 20.04)

[ethomson]

Thanks for this report as well, I'm glad that you're exercising the patch functionality.