New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.7.1: self test failures on Cygwin #6655
Comments
Interesting. Did prior versions work? Can you give some more details about your environment? I'm not very familiar with the state of the art with Cygwin. |
There is a bunch of It could explain the last failure in strcasecmp. |
Sorry, I have not checked with other versions.
The test is done with gcc version
|
Could you compile with #6679 and see if any of the tests passes? |
Version of libgit2 (release number or SHA1)CI resultActual Behavior
|
OK, I missed one isprint() in the pr, but I don't see that it would be cause any of the remaining failures. I don't really know why we are testing for sign in strcasecmp since its a posix-function that we don't overload. (There is a p_strcasecmp define that we don't use.)
But I don't see anything that requires the byte to be signed/unsigned. Functions that cares about signedness of strcasecmp with non-ascii characters will behave differently on systems where char is signed I suppose, but for that we have git__strcasecmp() that does unsigned compare. The rest of the fails feels a lot like Windows filesystem not behaving as one one expect from a POSIX system. I noticed that one of the cmakelists have a |
cmake built for cygwin has the following settings
-DWIN32, which causes a conflict with w32api and makes it difficult to compile.
|
As some time has passed since the last report, HEAD was tested again. Version of libgit2 (release number or SHA1)Actual Behavior
|
Reproduction steps
https://github.com/cygwin/scallywag/actions/runs/6831370933/job/18580898875
Expected behavior
All test pass
Actual behavior
Version of libgit2 (release number or SHA1)
1.7.1
Operating system(s) tested
Cygwin (x86-64)
The text was updated successfully, but these errors were encountered: