Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR @dropActive event #333

Open
DomasB opened this issue Jan 28, 2020 · 1 comment · May be fixed by #346
Open

FR @dropActive event #333

DomasB opened this issue Jan 28, 2020 · 1 comment · May be fixed by #346

Comments

@DomasB
Copy link

DomasB commented Jan 28, 2020

Using $refs to set a dropActive prop is not ideal as $refs is not reactive.
I would suggest emiting an event.
Simplest way to do it would be to add this.$emit('dropActive, true) near the places where this.dropActive = true is used in the source code and this.$emit('dropActive, false) where this.dropActive = false is used.

Should also solve the issue 254.

Thank you for your attention!
@JoshMoreno JoshMoreno linked a pull request Apr 5, 2020 that will close this issue
Open
@JoshMoreno
Copy link

For anyone who's having problems with this, see my pr #346 for workarounds until the pr gets merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add drop active event JoshMoreno/vue-upload-component
2 participants
@DomasB @JoshMoreno