Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong comments when calculating direction in ksw2_extd2_sse.c #22

Open
mimaric opened this issue Oct 1, 2021 · 0 comments
Open

Wrong comments when calculating direction in ksw2_extd2_sse.c #22

mimaric opened this issue Oct 1, 2021 · 0 comments

Comments

@mimaric
Copy link

mimaric commented Oct 1, 2021

Comment on

d = _mm_or_si128(d, _mm_and_si128(tmp, _mm_set1_epi8(0x08))); // d = a > 0? 1<<3 : 0
(and similar comments below) should read d |= a > 0? 1<<3 : 0 instead of d = a > 0? 1<<3 : 0.
Furthermore on
d = _mm_or_si128(d, _mm_andnot_si128(tmp, _mm_set1_epi8(0x08))); // d = a > 0? 1<<3 : 0
it should be d |= a >= 0? 1<<3 : 0 instead of d = a > 0? 1<<3 : 0 (note >= instead of >).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant