Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing Guide Update #350

Closed
tiokim opened this issue Aug 6, 2021 · 3 comments · Fixed by #352
Closed

Testing Guide Update #350

tiokim opened this issue Aug 6, 2021 · 3 comments · Fixed by #352
Assignees
@tdrozdovsky
Labels
bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@tiokim
Copy link
Contributor

tiokim commented Aug 6, 2021 •
edited

Testing Policy should have how to install coverage tool (gocov and gocov-html).

Error Log when coverage tools are not installed.

t25kim@t25kim:~/work/edge-home-orchestration-go$ make test
.
.
--------------------------------------
  build test for internal/...
--------------------------------------
make test-go TEST_PKG_DIRS="internal/..."
make[1]: Entering directory '/home/t25kim/work/edge-home-orchestration-go'
gocov test -v ./internal/... > coverage.out
/bin/sh: 1: gocov: not found

t25kim@t25kim:~/work/edge-home-orchestration-go$ go get github.com/axw/gocov/gocov
go get: added github.com/axw/gocov v1.0.0
t25kim@t25kim:~/work/edge-home-orchestration-go$ make test
.
.
github.com/lf-edge/edge-home-orchestration-go/internal/restinterface/tls/tls.go  SetHandler                              0.00% (0/1)
github.com/lf-edge/edge-home-orchestration-go/internal/restinterface/tls         -------------------------------------   94.44% (17/18)

Total Coverage: 73.75% (3071/4164)
gocov-html coverage.out > coverage.html
/bin/sh: 1: gocov-html: not found
@tiokim tiokim added bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed labels Aug 6, 2021
@tdrozdovsky
Copy link
Contributor

@t25kim Testing policy has been updated in #345

@tiokim
Copy link
Contributor Author

tiokim commented Aug 6, 2021 •
edited

@t25kim Testing policy has been updated in #345

@tdrozdovsky Sorry. I missed that PR.
I've updated the issue in terms of installation of coverage tools.

@tdrozdovsky tdrozdovsky self-assigned this Aug 6, 2021
@tdrozdovsky
Copy link
Contributor

I fix it as soon as possible

@tdrozdovsky tdrozdovsky mentioned this issue Aug 6, 2021
Merged
8 tasks
MoonkiHong pushed a commit that referenced this issue Aug 10, 2021
@tdrozdovsky
Update testing guide (#352)
d8d4518 
Signed-off-by: Taras Drozdovskyi <t.drozdovsky@samsung.com>

Adds instructions on how to install the gocov package and staticckeck tool for testing the project.
Fixes #350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdrozdovsky tdrozdovsky

Labels
bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update testing guide tdrozdovsky/edge-home-orchestration-go
2 participants
@tiokim @tdrozdovsky