Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUSPENDED] Ubuntu Version #289

Closed
tiokim opened this issue Mar 23, 2021 · 7 comments · Fixed by #290
Closed

[SUSPENDED] Ubuntu Version #289

tiokim opened this issue Mar 23, 2021 · 7 comments · Fixed by #290
Assignees
@MoonkiHong @mgjeong @tdrozdovsky @suresh-lc
Labels
good first issue Good for newcomers

Comments

@tiokim
Copy link
Contributor

tiokim commented Mar 23, 2021

Standard support for Ubuntu 16.04 LTS ends in April 2021.
I'd like to

  1. exclude Ubuntu 16.04 from the Build and Test Suite workflows.
  2. change the Ubuntu version of the Dockerfile from 16.04 to 20.04.
@tiokim tiokim added the good first issue Good for newcomers label Mar 23, 2021
@tdrozdovsky
Copy link
Contributor

I see that there are already some problems with ubuntu 16.04

@tiokim
Copy link
Contributor Author

tiokim commented Mar 23, 2021

I see that there are already some problems with ubuntu 16.04

@tdrozdovsky You're right. I noticed problems due to your PR #287 , #288.
Could you revise code in terms of workflows?

Regarding Dockerfile change, I'd like to give a chance for a new contributor.

@tdrozdovsky
Copy link
Contributor

@tdrozdovsky You're right. I noticed problems due to your PR #287 , #288.
Could you revise code in terms of workflows?

Yes of course I will do it

@tdrozdovsky
Copy link
Contributor

Regarding Dockerfile change, I'd like to give a chance for a new contributor.

@t25kim What do you have in mind?

@tiokim
Copy link
Contributor Author

tiokim commented Mar 23, 2021

Regarding Dockerfile change, I'd like to give a chance for a new contributor.

@t25kim What do you have in mind?

I'm going to have a toy project with some university students and would like to guide them how to contribute to open source through HomeEdge. I think changing the ubuntu version in Dockerfile is one of good contributing points.

@tdrozdovsky tdrozdovsky mentioned this issue Mar 23, 2021
Merged
8 tasks
@tdrozdovsky tdrozdovsky changed the title Ubuntu Version [SUSPENDED] Ubuntu Version Mar 23, 2021
@tdrozdovsky
Copy link
Contributor

While the github->Actions under Ubuntu-16.04 are working. Therefore, this issue is suspended.
In case of problems with the github->Actions under Ubuntu-16.04, the PR #290 is ready and can be applied as soon as possible

@tiokim
Copy link
Contributor Author

tiokim commented Mar 24, 2021

While the github->Actions under Ubuntu-16.04 are working. Therefore, this issue is suspended.
In case of problems with the github->Actions under Ubuntu-16.04, the PR #290 is ready and can be applied as soon as possible

In my opinion, no matter if workflows run or not, it would be nice to exclude the os if it ends standard support period.

MoonkiHong pushed a commit that referenced this issue Jul 7, 2021
@tdrozdovsky
Remove Ubuntu-16.04 as a target platform for build and test due to th…
4aba950 
…e end of the support of this OS (#290)

Signed-off-by: Taras Drozdovskyi <t.drozdovsky@gmail.com>

- Remove Ubuntu-16.04 as a target platform for build and test due to the end of the support of this OS
- Fixes #289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MoonkiHong MoonkiHong

@mgjeong mgjeong

@tdrozdovsky tdrozdovsky

@suresh-lc suresh-lc

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
5 participants
@tiokim @MoonkiHong @mgjeong @tdrozdovsky @suresh-lc