Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring] Build script #278

Closed
3 tasks done
tiokim opened this issue Feb 25, 2021 · 3 comments · Fixed by #279 or #281
Closed
3 tasks done

[Refactoring] Build script #278

tiokim opened this issue Feb 25, 2021 · 3 comments · Fixed by #279 or #281
Assignees
Labels
refactoring Any tasks and issues w.r.t. the code refactoring
Projects

Comments

@tiokim
Copy link
Contributor

tiokim commented Feb 25, 2021

How about refactoring build.sh file a little bit shorter?

  • Remove PKG_LIST and use a relative path to run test scenarios.
  • Streamline code in terms of BUILD_TAGS such as secure, mnedc.
  • Delete duplicated code that can be eliminated
@tiokim tiokim added the refactoring Any tasks and issues w.r.t. the code refactoring label Feb 25, 2021
@tiokim tiokim added this to To do in Refactoring via automation Feb 25, 2021
@suresh-lc
Copy link
Contributor

Good idea, we can remove duplicated code and check on refactoring the file. Check for all the functions and might be make separate .sh for functions. Just my thought, need to investigate how much it would add value. Lets check on refactoring to make build script simple and understandable.

@tiokim tiokim moved this from To do to In progress in Refactoring Feb 25, 2021
Refactoring automation moved this from In progress to Done Mar 2, 2021
@tiokim tiokim moved this from Done to In progress in Refactoring Mar 2, 2021
@tiokim tiokim reopened this Mar 2, 2021
@tdrozdovsky
Copy link
Contributor

I think that BUILD_TAGS: secure should be enabled by default (and I will try to do it soon). But for ease of development, I plan to add a BUILD_TAGS:unsecure, but only as a tag for the build!

@tiokim
Copy link
Contributor Author

tiokim commented Mar 3, 2021

I think that BUILD_TAGS: secure should be enabled by default (and I will try to do it soon). But for ease of development, I plan to add a BUILD_TAGS:unsecure, but only as a tag for the build!

@tdrozdovsky Thank you for sharing your idea. I hope to set secure as a default.
In order to do so, it seems that the usability of Security Manager should be improved.
Let's talk about security components like Verifier and Authenticator by opening a new issue.

Refactoring automation moved this from In progress to Done Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Any tasks and issues w.r.t. the code refactoring
Projects
4 participants