Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build System] Applying Go Modules instead of relying on Glide #206

Closed
MoonkiHong opened this issue Dec 30, 2020 · 4 comments · Fixed by #210
Closed

[Build System] Applying Go Modules instead of relying on Glide #206

MoonkiHong opened this issue Dec 30, 2020 · 4 comments · Fixed by #210
Assignees
@MoonkiHong
Labels
enhancement New feature or request refactoring Any tasks and issues w.r.t. the code refactoring

Comments

@MoonkiHong
Copy link
Contributor

MoonkiHong commented Dec 30, 2020 •
edited

Is your feature request related to a problem? Please describe.
The current edge-home-orchestration-go project is built from employing glide. Consequently, it is really challenging for us to employ those existing available open source projects based on the Go Modules build system. One good example is that we cannot apply the latest version of Docker Engine and the recent EdgeX features, which all are based on Go Modules. In addition to make this situation much worse, the 3rd party developers might encounter a huge difficulty in building their own applications powered by edge-home-orchestration-go, because most of them are using Go Modules instead of Glide. Especially, if there is a developer to use some subset of edge-home-orchestration-go, he/she should fully describe the regarding GitHub url about those subset packages into their import like github.com/lf-edge/edge-home-orchestration-go/src/common/logmgr instead of common/logmgr.

Describe the solution you'd like
Applying the new build system based on Go Modules and deprecating the Glide based build system.

Suggestion: LET US discuss this issue in the upcoming TSC online meeting in January 2021!!!
@MoonkiHong MoonkiHong added the enhancement New feature or request label Dec 30, 2020
@MoonkiHong MoonkiHong self-assigned this Dec 30, 2020
@MoonkiHong MoonkiHong mentioned this issue Dec 30, 2020
Closed
@tiokim
Copy link
Contributor

tiokim commented Dec 30, 2020

I deeply agree that this issue should be resolved.
I will open a PR regarding this as soon as possible for ease of discussion.

@tiokim tiokim added the refactoring Any tasks and issues w.r.t. the code refactoring label Dec 31, 2020
@tiokim tiokim mentioned this issue Jan 3, 2021
Merged
10 tasks
@suresh-lc
Copy link
Contributor

Good point brought out. We can discuss on this regard on Glide and Go Module on Jan month TSC call as mentioned.

@suresh-lc
Copy link
Contributor

suresh-lc commented Jan 4, 2021 •
edited

Came across a blog and seems good one : https://blog.golang.org/migrating-to-go-modules

@MoonkiHong
Copy link
Contributor Author

Came across a blog and seems good one : https://blog.golang.org/migrating-to-go-modules

@suresh-lc PTAL specifically about #210!

MoonkiHong pushed a commit that referenced this issue Jan 14, 2021
@tiokim
Migrate to Go Modules and update docker engine to v19.03.14 (#210)
dd18d22 
Signed-off-by: Taewan Kim <t25.kim@samsung.com>

- This PR is to support go modules (Fixes #206 #207)
- Update Docker pkgs to v19.03.14
- Tune packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MoonkiHong MoonkiHong

Labels
enhancement New feature or request refactoring Any tasks and issues w.r.t. the code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to Go Modules and update docker engine to v19.03.14 tiokim/edge-home-orchestration-go
3 participants
@tiokim @MoonkiHong @suresh-lc