Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataStorage] Two types of Logger #173

Closed
tiokim opened this issue Nov 11, 2020 · 2 comments
Closed

[DataStorage] Two types of Logger #173

tiokim opened this issue Nov 11, 2020 · 2 comments
Assignees
Labels
bug Something isn't working refactoring Any tasks and issues w.r.t. the code refactoring

Comments

@tiokim
Copy link
Contributor

tiokim commented Nov 11, 2020

DataStorage uses the package log and the logger of edgex.
As a result, there are separate log files for edgex and for edge-orchestration in /var/edge-orchestration/log/logmgr.log with different style.

level=INFO ts=2020-11-11T07:43:11.040198344Z app=datastorage source=init.go:138 msg="Check Metadata service's status ..."
level=INFO ts=2020-11-11T07:43:11.040289585Z app=datastorage source=init.go:138 msg="Check Data service's status ..."
level=ERROR ts=2020-11-11T07:43:11.042473566Z app=datastorage source=init.go:149 msg="Error getting ping: Get \"http://localhost:48081/api/v1/ping\": dial tcp 127.0.0.1:48081: connect: connection refused "
level=ERROR ts=2020-11-11T07:43:11.043495198Z app=datastorage source=init.go:149 msg="Error getting ping: Get \"http://localhost:48080/api/v1/ping\": dial tcp 127.0.0.1:48080: connect: connection refused "
2020/11/11 07:43:11 discovery.go:562: [deviceDetectionRoutine] edge-orchestration-3125da9e-1e9a-41aa-ac83-004725eb2d1e
2020/11/11 07:43:11 discovery.go:563: [deviceDetectionRoutine] confInfo    : ExecType(container), Platform(docker)
2020/11/11 07:43:11 discovery.go:564: [deviceDetectionRoutine] netInfo     : IPv4([]), RTT(0)
2020/11/11 07:43:11 discovery.go:565: [deviceDetectionRoutine] serviceInfo : Services([])
2020/11/11 07:43:11 discovery.go:566:

I think we should have same style at least.

@MoonkiHong MoonkiHong added bug Something isn't working refactoring Any tasks and issues w.r.t. the code refactoring labels Nov 11, 2020
@MoonkiHong
Copy link
Contributor

MoonkiHong commented Nov 11, 2020

Plus, what we would like to also consider about is as follows:

  1. Evaluate any needs to setup and/or employ the existing regarding standard way of log representation style;
  2. Evaluate any needs to setup an abstract layer to embrace a variety of log styles that any developers would rely on for their own perspective.

@suresh-lc @sun-sharma What do you think of your opinions about @t25kim and myself?

@suresh-lc
Copy link
Contributor

Good point brought out. Will check on making common logging style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactoring Any tasks and issues w.r.t. the code refactoring
Projects
None yet
Development

No branches or pull requests

4 participants