Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about merging current configuration db and serviceInfo db into one? #129

Closed
tiokim opened this issue Sep 3, 2020 · 4 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@tiokim
Copy link
Contributor

tiokim commented Sep 3, 2020

How about merging the configuration DB and the serviceInfo DB as follows and using the serviceInfo DB for different purpose such as collecting performance data(cpu, memory), version and so on?

Current

type Configuration struct {
	ID       string `json:"id"`
	Platform string `json:"platform"`
	ExecType string `json:"executionType"`
}
type ServiceInfo struct {
	ID       string   `json:"id"`
	Services []string `json:"services"`
}

Future

type Configuration struct {
	ID       string `json:"id"`
	Platform string `json:"platform"`
	ExecType string `json:"executionType"`
	Services []string `json:"services"`
}
@MoonkiHong
Copy link
Contributor

@Karthikeyan-Samsung @suresh-lc PTAL.

@tiokim
Copy link
Contributor Author

tiokim commented Sep 14, 2020

@MoonkiHong @Karthikeyan-Samsung @suresh-lc
I've tested the Edge Orchestration works as usual when the Configuration DB stores the lists of services.
Please consider this issue and review the proposed PR if this issue is all right.

@suresh-lc
Copy link
Contributor

Combining dbs into single one looks better from understanding point of view. But From development and maintainability point, its good to maintain as separate. This makes it simpler to update information properly and thus ensure data integrity. In future in case we want to limit services to particular requester that it would be better in case we have 2 different dbs. Also if we want to add other parameter like say based on device capability(Sensor) if offloading needs to be done, then say a capability db needs to be added. Hence its always better to have the dbs separate instead of merging into single. If merging into single db has strong point then we should think about it.

@tiokim tiokim closed this as completed Sep 14, 2020
@MoonkiHong
Copy link
Contributor

As described in #132 , let us keep discussing this topic including backward compatibility of the DB structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants