Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change api to work with multiple imgaes, restructure reposetory #1

Open
1 of 4 tasks
lexeyOK opened this issue Jan 7, 2023 · 0 comments
Open
1 of 4 tasks

Change api to work with multiple imgaes, restructure reposetory #1

lexeyOK opened this issue Jan 7, 2023 · 0 comments

Comments

@lexeyOK
Copy link
Owner

lexeyOK commented Jan 7, 2023

  • update cli to look similar to cli provided by https://github.com/GoogleChromeLabs/squoosh
    in multi file mode we sould be able to change from supported image formtats to qoi with maybe --qoi flag
    or just use the same logic we have now
qoiconv-rs image1.png image2.png image3.png -d directory_to_processed_files
qoiconv-rs <...files> --output-dir <path> --suffix <suffix> --jobs 4 # not sure about suffix one
# or 
qoiconv-rs <file> --output <path>

-o will not work in multi file mode
this should be working in parallel using rayon libary in multi file mode (allow to set number of jobs with -j )
also we want some progress bar so will need to probably add console crate

  • add tests for cli
  • revue how cli handles files from different folders
    • should we create output file just by changing Path of input file
    • or should we put output file in the place of execution?
  • remove lib to separate crate or workspace ( monorepo vs separate repos ) alternatively change binary to be associated binary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant