Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable luarocks test #913

Open
Tracked by #267072
teto opened this issue Nov 7, 2023 · 3 comments
Open
Tracked by #267072

enable luarocks test #913

teto opened this issue Nov 7, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@teto
Copy link
Contributor

teto commented Nov 7, 2023

Is your feature request related to a problem? Please describe.
I would like luarocks test to work out of the box, ie., let luarocks be able to run the gitsigns.nvim testsuite

   > building
   > running tests
   >
   > Error: could not detect test type -- no test suite for gitsigns.nvim?

Describe the solution you'd like
Looking at the luarocks code, one can:

  • add a .busted file at the root
  • add test.type = "busted" in the rockspec .

https://github.com/luarocks/luarocks/wiki/test

Describe alternatives you've considered
I am able to run the tests manually but luarocks test creates a convention that can work across packages and as a package manager, it makes my work easier. Also going through luarocks, you can specify dependencies just for tests.

Additional context
I think I hit #847 so I thought this would be a good time to enable tests in the nixpkgs gitsigns-nvim package but then hit > Error: could not detect test type -- no test suite for gitsigns.nvim?. I can perfectly work around it but having lua packages/neovim plugins support luarocks test would make that a ton easier. gitsigns being very popular, it can set a good example.

@teto teto added the enhancement New feature or request label Nov 7, 2023
@lewis6991
Copy link
Owner

FYI I've kinda given up on Luarocks so this isn't something I'll want to work on.

@lewis6991
Copy link
Owner

Also the testsuite uses nvim -l as the lua interpreter, not sure if luarocks can support that.

@mrcjkb
Copy link
Contributor

mrcjkb commented Nov 7, 2023

this can be used as a wrapper for nvim -l with luarocks. I plan on packaging it for luarocks sometime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants