Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow maximum height setting for popup #843

Closed
wants to merge 2 commits into from

Conversation

ribru17
Copy link

@ribru17 ribru17 commented Jul 21, 2023

Fixes #804

@ribru17
Copy link
Author

ribru17 commented Jul 27, 2023

@lewis6991 in case you missed this PR

@lewis6991
Copy link
Owner

I'm not sure I want to add additional surface area to the API to support a niche request like this.

I appreciate you made the change, but often with these kinds of contributions, it solves a very specific problem with a low effort solution, and the maintainers are left to support this new API going forward.

If exposing the ability to configure the preview window is something we add, then it should be done in a more generalized way to better allow further additions in the future.

@ribru17
Copy link
Author

ribru17 commented Jul 27, 2023

I see; is there anything actionable I can do to improve this PR in hopes of a future merge or should this just be left alone for now?

@lewis6991
Copy link
Owner

Probably not in the PR, but we can leave the issue open so the request is tracked.

@ribru17 ribru17 closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to change max height of preview window
2 participants