Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some linematch hunks need topdelete #701

Open
lewis6991 opened this issue Dec 30, 2022 · 2 comments · Fixed by #954
Open

some linematch hunks need topdelete #701

lewis6991 opened this issue Dec 30, 2022 · 2 comments · Fixed by #954
Labels
bug Something isn't working

Comments

@lewis6991
Copy link
Owner

lewis6991 commented Dec 30, 2022

Description

image

There are no signs for the bottom hunk since the modified position is taking its place.

@lewis6991 lewis6991 added the bug Something isn't working label Dec 30, 2022
@clktmr
Copy link
Contributor

clktmr commented Mar 11, 2024

IMHO this should show a changedelete symbol on line 105. If there were another change after line 105 linematch would report 5 hunks (delete, change, delete, change, delete), in which case topdelete could be used for the last hunk, but the second delete would still have no sign.
I opened #954 which implements this. However the issue still exists that some hunks will not show up when show_preview is called. I think show_preview must check for multiple hunks on line to fix this.

@lewis6991
Copy link
Owner Author

If there were another change after line 105 linematch would report 5 hunks (delete, change, delete, change, delete), in which case topdelete could be used for the last hunk, but the second delete would still have no sign.

Yes, this is one edge case in which changedelete is still needed, however I still think topdelete should be preferred where is makes sense since it has a different highlight to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants