Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper checks and show warnings to users against incorrect configuration #882

Closed
7 of 13 tasks
tedenda opened this issue Feb 15, 2018 · 8 comments
Closed
7 of 13 tasks

Add proper checks and show warnings to users against incorrect configuration #882

tedenda opened this issue Feb 15, 2018 · 8 comments
Assignees
@TD-er @Grovkillen
Labels
Category: Frontend Related to web-interface Category: UX Related to operating ESP-easy Status: In Progress Is being worked on by the development team Type: Feature Request Add a completely new feature (e.g. controller/plugin)
Projects
Improve UX
Milestone
2.2.0 "KNOX"

Comments

@tedenda
Copy link
Contributor

tedenda commented Feb 15, 2018 •
edited by TD-er

  • Tell user that PulseCounter only works on task 1-4 if configured on task 5-12
  • Do not use same name of tasks
  • When changing a name which is used in some rule, add a warning
  • Add a warning when a hostname cannot be resolved
  • Add a warning when a device cannot be detected in a plugin/task (e.g. I2C devices)
  • Add warning/error when delay is set to a too low value in a plugin/task
  • Max length on task namn, value name
  • Check that task and value name is different
  • Check for non valid chars in names
  • Validate unit number
  • Show a warning when performing OTA on a 1MB flash device
  • Set msg delay to 100 ms when using a switch
  • Check IP settings for all values be filled or none (DHCP)
@TD-er
Copy link
Member

TD-er commented Feb 15, 2018 •
edited

Also good to check:

  • Do not use same name of tasks.
  • When changing a name which is used in some rule, add a warning.
  • Add a warning when a hostname cannot be resolved.
  • Add a warning when a device cannot be detected in a plugin/task (e.g. I2C devices)
  • Add warning/error when delay is set to a too low value in a plugin/task.

@Grovkillen
Copy link
Member

Length of task name, value name should also be included in the scope. Also it's not recommended to have the same name for task and value. Spaces is names are also a no-go.

@Grovkillen Grovkillen added Type: Enhancement Improve something already present Category: Frontend Related to web-interface labels Feb 17, 2018
@Grovkillen Grovkillen added this to the 2.0.0 milestone Feb 17, 2018
@s0170071
Copy link
Contributor

@tedenda: When adding a task is not working- what does the FreeMem line on the main webpage read ?
e.g.

Free Mem: | 18544 (13888 - duringDataTX)

@TD-er
Copy link
Member

TD-er commented Feb 26, 2018

Do not allow characters other than numbers for the unit number.
See forum

@TD-er TD-er mentioned this issue Feb 27, 2018
Closed
@TD-er
Copy link
Member

TD-er commented Feb 27, 2018

Show a warning when performing OTA on a 1MB flash device.
Suggested here.

@TD-er TD-er changed the title Make user aware that some plugins only work on certain task numbers Add proper checks and show warnings to users against incorrect configuration Feb 27, 2018
@TD-er TD-er self-assigned this Feb 27, 2018
@TD-er TD-er added Type: Feature Request Add a completely new feature (e.g. controller/plugin) and removed Type: Enhancement Improve something already present labels Mar 2, 2018
@TD-er
Copy link
Member

TD-er commented Mar 2, 2018

Set msg delay to 100 ms when using a switch.
See forum

@ghost ghost modified the milestones: 2.0.0, 2.1.0 Mar 22, 2018
@TD-er TD-er added the Category: UX Related to operating ESP-easy label Mar 28, 2018
@TD-er TD-er mentioned this issue Mar 28, 2018
Closed
tedenda added a commit to tedenda/ESPEasy that referenced this issue May 21, 2018
@tedenda
Add note for PulseCounter
306b217 
I added a note if you choose PulseCounter on task 5-12.
Part of letscontrolit#882
@tedenda tedenda mentioned this issue May 21, 2018
Merged
TD-er added a commit to TD-er/ESPEasy that referenced this issue Jul 29, 2018
@TD-er
[letscontrolit#882] Add checks on names in task setup
a6a45dd 
When saving a task, a warning or error is displayed (when appropriate) when the settings are saved.
@TD-er TD-er added this to Needs triage in Improve UX via automation Jul 29, 2018
TD-er added a commit to TD-er/ESPEasy that referenced this issue Jul 29, 2018
@TD-er
[letscontrolit#882] Add checks on names in task setup
90febfd 
When saving a task, a warning or error is displayed (when appropriate) when the settings are saved.
@TD-er TD-er moved this from Needs triage to In progress in Improve UX Jul 30, 2018
@TD-er TD-er added the Status: In Progress Is being worked on by the development team label Jul 30, 2018
@Grovkillen Grovkillen self-assigned this Jan 10, 2020
@tedenda
Copy link
Contributor Author

tedenda commented Dec 24, 2022

Can I close this issue?
Last edited 5y ago.

@tonhuisman
Copy link
Contributor

Can I close this issue? Last edited 5y ago.

Yes, as many configuration checks (and other improvements) have been implemented.

@tedenda tedenda closed this as completed Dec 24, 2022
Improve UX automation moved this from In progress to Closed Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TD-er TD-er

@Grovkillen Grovkillen

Labels
Category: Frontend Related to web-interface Category: UX Related to operating ESP-easy Status: In Progress Is being worked on by the development team Type: Feature Request Add a completely new feature (e.g. controller/plugin)
Projects
Improve UX
  
Closed
Milestone
2.2.0 "KNOX"
Development

No branches or pull requests
5 participants
@tonhuisman @TD-er @tedenda @Grovkillen @s0170071