Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to sklearn nightly builds? #3

Open
amueller opened this issue Oct 14, 2022 · 2 comments
Open

move to sklearn nightly builds? #3

amueller opened this issue Oct 14, 2022 · 2 comments

Comments

@amueller
Copy link

Should we add this to sklearn CI? What are the hurdles?
@thomasjpfan said he's ok with having it fail on a nightly ;)

@rth
Copy link
Collaborator

rth commented Oct 15, 2022

There is a similar plan to add it to numpy CI in numpy/numpy#21895

So scikit-learn nightly could also make sense eventually. But to start, and make the CI pass it's indeed probably easier to have this standalone repo.

BTW, pydantic-core has also been running it in CI for some time now.

@lesteve
Copy link
Owner

lesteve commented Oct 18, 2022

I agree that a standalone repo makes it a lot easier to quickly iterate on this and see what is the state we are in before thinking of adding a CI build to the scikit-learn/scikit-learn repo.

When scikit-learn/scikit-learn#24682 is merged we can get at least pyodide build to work on the scikit-learn main branch which is a start.

About hurdles, there are plenty of test failures right now that needs investigating. See https://github.com/lesteve/scikit-learn-tests-pyodide#manually-curated-list-of-issues for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants