Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong multInner implementation chosen by matrix size condition #58

Open
rekobo opened this issue Jul 29, 2019 · 1 comment
Open

Wrong multInner implementation chosen by matrix size condition #58

rekobo opened this issue Jul 29, 2019 · 1 comment
Assignees

Comments

@rekobo
Copy link

rekobo commented Jul 29, 2019

Hi,
there is a flipped condition in CommonOps_DDRM.multInner, which results in a less than optimal (sorry:) ) algorithm being picked.

`

    if( a.numCols >= EjmlParameters.MULT_INNER_SWITCH ) {
        MatrixMultProduct_DDRM.inner_small(a, c);
    } else {
        MatrixMultProduct_DDRM.inner_reorder(a, c);
    }

`

There's the same thing in FDRM as well.

@rekobo rekobo changed the title Wrong multInner implementation chosen by matrix size size Wrong multInner implementation chosen by matrix size condition Jul 29, 2019
@lessthanoptimal lessthanoptimal self-assigned this Jul 31, 2019
@lessthanoptimal
Copy link
Owner

I think you're right, but I want to double check with a performance benchmark to make sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants