Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode-only icons for the visual fingerprint #776

Open
KaKi87 opened this issue Jun 21, 2023 · 2 comments
Open

Unicode-only icons for the visual fingerprint #776

KaKi87 opened this issue Jun 21, 2023 · 2 comments

Comments

@KaKi87
Copy link

KaKi87 commented Jun 21, 2023

Hello,

Out of the 46 icons used by the visual fingerprint,

18 are part of Unicode :
  • heart
  • hotel
  • ambulance
  • bus
  • rocket
  • ship
  • truck
  • bed
  • beer
  • bell
  • bomb
  • briefcase
  • bug
  • camera
  • coffee
  • cloud
  • coffee
  • eye
28 are not :
  • hashtag
  • university
  • plug
  • car
  • plane
  • subway
  • jpy
  • eur
  • btc
  • usd
  • gbp
  • archive
  • area-chart
  • binoculars
  • birthday-cake
  • cart-plus
  • certificate
  • comment
  • cube
  • cutlery
  • database
  • diamond
  • exclamation-circle
  • flag
  • flask
  • futbol-o
  • gamepad
  • graduation-cap

It would be nice to replace the latter with Unicode ones so that the visual fingerprint could be used in CLI apps like it can be used in GUI apps.

Thanks

@edouard-lopez
Copy link
Member

edouard-lopez commented Jun 22, 2023

Icons are already supported on the CLI,

Related: tests file, MR #402

But it might not supported on all Terminal/shell applications. For instance, I don't have it on Guake+Tmux+Fish but have it in GNOME Terminal.

Also check that LESSPASS_MASTER_PASSWORD otherwise it won't prompt you the master password, so no icons.

Preview

lesspass-cli-fingerprint-icon.webm

We should improve the wiki page Visual Fingerprint to add configuration known to work for the CLI

@KaKi87
Copy link
Author

KaKi87 commented Jun 22, 2023

Well, yes indeed, because Font Awesome icons that don't exist in Unicode (e.g. : fa-database) were replaced by other Unicode icons (e.g. : computer) :

["fa-hashtag", "#️"],
["fa-heart", "❤️"],
["fa-hotel", "🏨"],
["fa-university", "🎓"],
["fa-plug", "🔌"],
["fa-ambulance", "🚑"],
["fa-bus", "🚌"],
["fa-car", "🚗"],
["fa-plane", "✈️"],
["fa-rocket", "🚀"],
["fa-ship", "🚢"],
["fa-subway", "🚇"],
["fa-truck", "🚚"],
["fa-jpy", "💴"],
["fa-eur", "💶"],
["fa-btc", "₿"],
["fa-usd", "💵"],
["fa-gbp", "💷"],
["fa-archive", "🗄️"],
["fa-area-chart", "📈"],
["fa-bed", "🛏️"],
["fa-beer", "🍺"],
["fa-bell", "🔔"],
["fa-binoculars", "🔭"],
["fa-birthday-cake", "🎂"],
["fa-bomb", "💣"],
["fa-briefcase", "💼"],
["fa-bug", "🐛"],
["fa-camera", "📷"],
["fa-cart-plus", "🛒"],
["fa-certificate", "⭐"],
["fa-coffee", "☕"],
["fa-cloud", "☁️"],
["fa-coffee", "☕"],
["fa-comment", "🗨️"],
["fa-cube", "📦"],
["fa-cutlery", "🍴"],
["fa-database", "🖥️"],
["fa-diamond", "💎"],
["fa-exclamation-circle", "❗"],
["fa-eye", "👁️"],
["fa-flag", "🏁"],
["fa-flask", "⚗️"],
["fa-futbol-o", "⚽"],
["fa-gamepad", "🎮"],
["fa-graduation-cap", "🎓"],

Therefore, my suggestion still stands, but more specifically, it now consists in : using in GUI the same icons that are used in CLI (e.g. : fa-computer instead of fa-database).

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants