Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI allows negative values... #203

Closed
panther2 opened this issue Apr 7, 2017 · 5 comments
Closed

GUI allows negative values... #203

panther2 opened this issue Apr 7, 2017 · 5 comments
Labels

Comments

@panther2
Copy link
Contributor

panther2 commented Apr 7, 2017

... or positive but lower than intended values - and (of course) fails to create a password then:

lp

This is from the Website.
The same is valid for the Chrome extension, too.

Chrome console shows this:

lpx

@Kcchouette
Copy link
Contributor

Kcchouette commented Apr 7, 2017

I think the javascript command overwrite the html limitation fixed by the code (on the lesspass-pure, ` v-on:click="options.length+=1").

A verification like SiteLoginMasterPasswordMandatory should do the trick

@edouard-lopez
Copy link
Member

edouard-lopez commented Apr 7, 2017

Thanks, I can reproduce.

It is similar to #133.

Glad to see you use the german translation :)

@edouard-lopez
Copy link
Member

@guillaumevincent could you review lesspass/pure@afe7700, build and push?

@panther2
Copy link
Contributor Author

panther2 commented Apr 11, 2017

@guillaumevincent @edouard-lopez
In the (Windows) desktop app the restrictions apply now.
I suppose the browser extension(s) take some time to update?
Also on lesspass.com I can still enter negative values.

@guillaumevincent
Copy link
Member

@panther2 yes, I'm working on #194 and try to push webextension automatically
It will be soon on Chrome, and in 2 weeks for Firefox web extension :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants