[Compile Error] Conflict between less@3.0.0-alpha.3 and antd@2.13.4

[Coodool]

Version

less@3.0.0-alpha.3
antd@2.13.4

Steps to reproduce

Compile the antd.less directly in the CLI:

lessc ./node_modules/antd/dist/antd.less

Error log

FileError: './themes/default' wasn't found. Tried - D:\Projects\ncslab\node_modules\antd\lib\style\themes\default,D:\Projects\ncslab\node_modules\antd\dist\themes\default,D:\Projects\ncslab\node_modules\themes\default,themes\default.less in D:\Projects\ncslab\node_modules\antd\lib\style\index.less on line 1, column 1:
1 @import "./themes/default";
2 @import "./core/index";

Additional comment

It goes well with less@2.7.1.

Click here for more discussion in ant-design

[matthew-dean]

Thanks for reporting.

[afc163]

ping~

[jcgertig]

Needed

[ram-mar]

Faced the same issue, occurs in all 3.0.* versions - both in alpha and stable versions.

[yesmeck]

It seems less 3 does not support the function hack anymore, @matthew-dean could you confirm it?

[yesmeck]

The FileError: './themes/default' wasn't found error seems was fixed already. I encounter another error which was reported in #3182.

The reason is the bezierEasingMixin function doesn't have a return value, and the parser will try to parse the undefined value which leads the error.

[seven-phases-max]

@yesmeck For your first question the answer is: "inine javascript is disabled by default" (see changelog).

[yesmeck]

@seven-phases-max Thanks for the response, I'm looking into this issue, and got an error when compile custom function, so I ask the question here.

I found the reason as I commented above, but I don't understand less codebase very well, so I can't figure out how to fix it. Could you take a look?

[seven-phases-max]

Regarding the "inline javascript" - use plugins instead.

[yesmeck]

Looks good, we don't need the hack anymore, thanks!

[seven-phases-max]

Just FYI, this plugin functionality ("custom functions via @plugin") was available since around 2015.

[yesmeck]

Thanks!

[matthew-dean]

It seems less 3 does not support the function hack anymore, @matthew-dean could you confirm it?

Inline JS was never designed for that purpose, and yes, it's now disabled by default for security reasons. Even without @plugin syntax, Less plugins have been around for a long time and have been the intended tool for adding functions. But with @plugin, it's even more powerful, because you can isolate your declared functions to Less scope. (Visitors added by @plugin are still global.)

[matthew-dean]

This mainly seems to be an Inline JavaScript / less configuration issue and not a bug.

If the only issue is:

The reason is the bezierEasingMixin function doesn't have a return value, and the parser will try to parse the undefined value which leads the error.

That may be valid. Leaving open but downgrading this issue.

[seven-phases-max]

I'm about to close this ticket (in favour of reopened #3182) - because the original issue is solved somehow (how?) and for another issue ("antd is abusing some never specified inline js behaviour which is no longer there") it should be a new one. Please, let's not have these "all-in-one" tickets that are impossible to track.

[matthew-dean]

Closing this alpha bug and moving to #3182.