Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few PR not considered when generating change log #781

Open
WasiqB opened this issue Jul 3, 2022 · 3 comments
Open

Few PR not considered when generating change log #781

WasiqB opened this issue Jul 3, 2022 · 3 comments

Comments

@WasiqB
Copy link

WasiqB commented Jul 3, 2022

In my repository, Boyka-framework, I am using lerna-changelog to generate the change logs for Release.

Today I was checking the what change log will get generated when I will release a new version, and during this analysis I came to know that 2 of my PRs out of 40 closed / merged PR are not showing up in the generated Change logs.

The following PR's which are not getting considered are even when proper labels are attached:

Is this behaviour intended or is there some issue with lerna-changelog?

@abeforgit
Copy link

We're seeing similar problems in our project, were the 2 prs closed soon before you generated the changelog by any chance? We're suspecting that timing has something to do with it and we think it's often recently merged prs that get dropped

@slorber
Copy link

slorber commented Jan 27, 2023

Same here, seems it's missing a few changelog entries

cf PR: facebook/docusaurus#8585
VS output of: yarn changelog --from docusaurus-v2 --to slorber/docusaurus-v2.3-backport

The from/to is exactly the from/to branches of the PR, and the changelog output does not match the commits of my PR.


Note: this PR is a "backport PR" where I cherry-picked already existing PR commits one by one. I'm not 100% sure but it looks like the commits not appearing in the changelog are related to cherry-picks on which I had conflicts that I had to resolve/commit manually. Maybe it's because those commits have the label with #pr-hash instead of (#pr-hash)? Do brackets in the commit message matter?

@abeforgit
Copy link

note we (almost) never cherry-pick and still see dropped prs, there may be multiple issues playing here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants