Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems when trying to run this without github issues #314

Open
bob569 opened this issue May 13, 2020 · 4 comments
Open

Problems when trying to run this without github issues #314

bob569 opened this issue May 13, 2020 · 4 comments

Comments

@bob569
Copy link

bob569 commented May 13, 2020

Hey guys I'm trying to set this up in my monorepo that I'm playing with. I've got the following settings in my lerna.json:

"changelog": {
    "repo": "xxx/my_repo",
    "labels": {
      "tag: new feature": ":rocket: New Feature",
      "tag: breaking change": ":boom: Breaking Change",
      "tag: bug fix": ":bug: Bug Fix",
      "tag: enhancement": ":nail_care: Enhancement",
      "tag: documentation": ":memo: Documentation",
      "tag: internal": ":house: Internal",
      "tag: underlying tools": ":hammer: Underlying Tools"
    },
    "cacheDir": ".changelog"
  }

However when I try to run this tool I keep seeing:

{"message":"Not Found","documentation_url":"https://developer.github.com/v3/issues/#get-a-single-issue"}

Debugging this it looks like it is trying to make a call to /repo/issues/{issuenumber}

But I don't have any issues? (I only have two PRs I created to test). I'm not sure what I'm doing wrong, can anyone help?

Thanks!

@Turbo87
Copy link
Contributor

Turbo87 commented May 14, 2020

But I don't have any issues? (I only have two PRs I created to test). I'm not sure what I'm doing wrong, can anyone help?

issues and pull requests are available at the same API endpoint, which is why issues is used here.

are you trying this on a private repo?

@bob569
Copy link
Author

bob569 commented May 14, 2020

Hi yes that's correct it's a private repo. I reset my master branch to a single commit, checked out a new branch and committed some code. If I open a PR, tag it with a label and edit the title to not include the number then it seems to not break:

Screenshot 2020-05-14 at 18 40 50

But then when I run lerna-changelog nothing happens. Is there a guide I can follow or am I just being stupid? Sorry

@Turbo87
Copy link
Contributor

Turbo87 commented May 15, 2020

did you make sure that your GitHub access token has access to your private repo?

@bob569
Copy link
Author

bob569 commented May 15, 2020

Hi yes the calls to the github api resolve successfully, would it be useful to share the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants