Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit commiters line in markdown #295

Open
petrch87 opened this issue Apr 17, 2020 · 3 comments
Open

Omit commiters line in markdown #295

petrch87 opened this issue Apr 17, 2020 · 3 comments

Comments

@petrch87
Copy link

if I don't want to have commiters in changelog, i can provide "ignoreCommitters": [""] as an option, but there is still Committers: 0 in changelog, which is a redundant line at that point.

I would suggest:

1. adding omitCommiters: boolean to options

2. or extend the following condition

if (release.contributors) {
      markdown += `\n\n${this.renderContributorList(release.contributors)}`;
 }

to

if (release.contributors?.length) {
      markdown += `\n\n${this.renderContributorList(release.contributors)}`;
 }
@emmenko
Copy link
Contributor

emmenko commented Apr 17, 2020

Option 2 would be better. Would you mind opening a PR?

@petrch87
Copy link
Author

Sure

@petrch87
Copy link
Author

#296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants