Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve PR's for commits from new GitHub API #157

Open
rwjblue opened this issue Oct 22, 2019 · 2 comments
Open

Retrieve PR's for commits from new GitHub API #157

rwjblue opened this issue Oct 22, 2019 · 2 comments

Comments

@rwjblue
Copy link
Contributor

rwjblue commented Oct 22, 2019

GitHub introduced a new API for determining which PR a commit came from, we could use this API to avoid the multiple regular expression matchers that we are having to use today (e.g. the "squash and merge" style, the "merge commit" style, "homu", etc).

References:

@simonihmig
Copy link

This seems very useful, to make the detection stable.

I just played around with my IDE's (JetBrains) ability to interact with the Github APIs, in this case reviewing and merging a PR. Apparently it caused the merge commit to have a different message than usual:

image

The from part is missing from this regex, so didn't get any changelog information...

@thibaultdalban
Copy link

Could it allow to use lerna-changelog with PRs rebased and not only merged or squashed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants