Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseRenderer should be abstract class #264

Open
Spenhouet opened this issue Jan 3, 2021 · 0 comments
Open

BaseRenderer should be abstract class #264

Spenhouet opened this issue Jan 3, 2021 · 0 comments

Comments

@Spenhouet
Copy link
Contributor

Your design for v2 allows for the definition of new renderers.

To implement new classes which should follow some structure and implement some methods it is crucial to have the base class (BaseRenderer) be implemented as abstract class.

Please consider implementing the BaseRenderer as abstract class: https://docs.python.org/3/library/abc.html
I'm also missing something like that for the plugins.

This will make the implementation of new compatible renderers much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant