Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

native-tls included in dependencies even with rustls enabled #25

Closed
seanpianka opened this issue Apr 15, 2024 · 4 comments
Closed

native-tls included in dependencies even with rustls enabled #25

seanpianka opened this issue Apr 15, 2024 · 4 comments

Comments

@seanpianka
Copy link
Contributor

seanpianka commented Apr 15, 2024

Hello 馃憢

I upgraded from 2.x to 3.x and saw that native-tls features for reqwest are included in the build, even when the rustls feature is specified for the google_maps crate. It would seem that this new dependency for reqwest-maybe-middleware causes this. I don't know much about this project, but considering it has no README, no stars, and seems to be relatively inactive, it may be best to just include its source code into the project (or fork it, publish your own version, and maintain it separately).

Additionally, it would be helpful to upgrade reqwest to 0.12 from 0.11.

Thanks!

@leontoeides
Copy link
Owner

Good afternoon Sean 馃憢 I was holding out for an update on reqwest-maybe-middleware. I was thinking the same thing - if we don't have an update by next weekend I'll just fork it. It's very small. Also, great catch on the reqwest features being pulled in through that crate.

Thanks again for your feedback and advice. I really appreciate it!

@seanpianka
Copy link
Contributor Author

Happy to help. It looks like the newest release of that crate is available now.

@leontoeides
Copy link
Owner

Good morning Sean. I just published 3.5.0 and I forgot to check into this issue before I published. How are things looking on your end?

@leontoeides
Copy link
Owner

I think your issue has been addressed. Feel free to open again if it hasn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants