Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why test for history file in configuration snippets in README? #50

Open
jrd-oje opened this issue Nov 19, 2023 · 0 comments
Open

Why test for history file in configuration snippets in README? #50

jrd-oje opened this issue Nov 19, 2023 · 0 comments

Comments

@jrd-oje
Copy link

jrd-oje commented Nov 19, 2023

Hi, thanks for your life-changing script. I especially admire anyone who tries to stay posix compliant and not bash out.

Unfortunately, I don't understand why the configuration snippets in the README test for the existence of the history file. After all, theme -l gives a valid output whether the file exists or not. The snippets didn't work for me at first because I set XDG_CONFIG_HOME and the awk statements in theme.sh determine the location of the history file with the environment variables:

config_dir = (ENVIRON["XDG_CONFIG_HOME"] ?  ENVIRON["XDG_CONFIG_HOME"] : ENVIRON["HOME"])

histfile = config_dir"/.theme_history"

If there is no error in my logic, here is already a PR for the change.

@jrd-oje jrd-oje changed the title Why test for history file in configurations snippets? Why test for history file in configuration snippets? Nov 19, 2023
@jrd-oje jrd-oje changed the title Why test for history file in configuration snippets? Why test for history file in configuration snippets in README? Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant