New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
query
with alternative records dependency on different alt
#1092
Comments
I assume it is because Line 1055 in fcf31cb
EDIT: probably not. At least doesnt change the dependencies if I comment out both |
This is my SQL query to check what dependencies have been recorded after a clean build. The count does not change if I create the query, but it changes as soon as I iteratate over the entries, or if I get the parents children ( select artifact,source from artifacts where artifact like "de/%" and source like "%+en.lr"; |
This should fix it. But what about this? This is missing the alt too. However, I cannot assess how it affects attachements. Lines 762 to 767 in fcf31cb
|
@dairiki ok, my last comment needs an alt too to fix attachment queries. E.g., |
Attachments do have an alt attribute, I think. (It only affects the attributes stored in associated |
That was not the question. Yes, Attachments do have an alt attribute, as you said, for
EDIT: also, I do not use attachement alternatives. This is a general problem. |
Apologies for any incoherence. I've had a head-cold for the week and am not thinking all that clearly... I just meant to point out that I think this is probably, indeed a bug. There are probably other similar issues in the dependency tracking, as well, where unnecessary dependencies are being recorded. (It's worth noting that recording unnecessary dependencies is a much more benign bug than missing a necessary dependency. The later can result in missed rebuilds and stale output artifacts, while the former only results in slower rebuilds.) In the case of attachments, does the attachment need to declare a dependency on any of its parent's Can changes in any of those |
What about image croping and scaling? Will that be recorded by the template? For example, if the parent has a width property. Does that / should that creates a dependency on the parent or on the template only? Or how about image alt metadata, will that be a proper dependency? ... I am just shooting in the dark what the expected bahavior is. Get well soon :) |
This seems also to cause problems. It gets the parent with primary alt instead of currently used alt. Line 1497 in fcf31cb
|
Lets say, I use
site.query('/path', this.alt)|list
in a template. This will not only include the records of the provided alt, but also the records for the default alt.Assuming the default alt is EN:
layout-en.html
withquery('/pages', alt='en')
tracks dependency onpage1-en.html
andpage2-en.html
.layout-de.html
withquery('/pages', alt='de')
tracks dependency onpage1-en.html
,page2-en.html
,page1-de.html
, andpage2-de.html
.The text was updated successfully, but these errors were encountered: