Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we deprecate portable_popen and locate_executable? #1071

Open
dairiki opened this issue Sep 13, 2022 · 0 comments
Open

Can we deprecate portable_popen and locate_executable? #1071

dairiki opened this issue Sep 13, 2022 · 0 comments
Labels
bitrot Issues having to do with changes in external (or the standard) libraries

Comments

@dairiki
Copy link
Contributor

dairiki commented Sep 13, 2022

Lektor currently provides lektor.utils.portable_popen and lektor.utils.locate_executable.

Locate_executable seems to be largely identical or equivalent to the standard library shutil.which.

Does subprocess.Popen really still need help to work on Windows?
(The big red warning on the Popen docs does say, essentially, that any path modifications implied by the cwd or env parameters to Popen may not work as desired on Windows — the advice being to resolve the full path to the executable manually using shutil.which. I'm not sure it's an issue at all if the cwd or env parameters are not being used.)

@dairiki dairiki added the bitrot Issues having to do with changes in external (or the standard) libraries label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitrot Issues having to do with changes in external (or the standard) libraries
Projects
None yet
Development

No branches or pull requests

1 participant