Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref links aren't styled consistently #272

Open
nixjdm opened this issue Apr 12, 2019 · 4 comments
Open

ref links aren't styled consistently #272

nixjdm opened this issue Apr 12, 2019 · 4 comments

Comments

@nixjdm
Copy link
Member

nixjdm commented Apr 12, 2019

Notably, there are many links on the plugins pages that have class="ref", where the intended style font-style: italic; is not being applied. I believe that only works right now on docs pages. A number of links don't stand out well because of this.

@nixjdm
Copy link
Member Author

nixjdm commented Apr 12, 2019

@3kori
Copy link
Contributor

3kori commented Mar 13, 2023

Please assign me this issue. Thank you.

@dairiki
Copy link
Contributor

dairiki commented Mar 14, 2023

@3kori Thank you for your offer to help! Please note that PRs are always entertained, whether or not you've been "assigned" an issue.

@dairiki
Copy link
Contributor

dairiki commented Mar 14, 2023

If anyone is going to put significant effort and thought into this:

It seems that our markdown-link-classes code should be able to automatically distinguish between internal and external links (based on the absence or presence of a netloc in the link URL, respectively) and automatically apply the correct class(es) to the link.

(If, for some reason, that's not the case, we could use some sort of (meta) documentation (for lektor-website authors) regarding when to use what link classes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants