Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use default track and label other audio tracks #94

Open
SethFalco opened this issue Jun 11, 2023 · 0 comments
Open

feat: use default track and label other audio tracks #94

SethFalco opened this issue Jun 11, 2023 · 0 comments

Comments

@SethFalco
Copy link
Contributor

SethFalco commented Jun 11, 2023

Atm, there are some issues when channels use the audio-tracks feature on YouTube.

Namely:

  1. It doesn't use the default/original audio-track by default.
  2. All audio-tracks are unlabeled.

I was looking into this, but found it'd be best to leave an issue open and come back to it later.

This is technically possible to resolve already, but it'll be best to wait for this PR to be merged/released first:

Namely, this snippet:
https://github.com/iv-org/invidious/pull/3620/files#diff-2e15ef15316a1d99f1f4b03a18c0e632f5c55d2c661318aa2f8bfe5beace3589R104

It looks like that should tweak the API endpoint to make handling this much simpler.

Once that PR is merged:

  1. We use the default track by default.
  2. We label all audio tracks with iso_code.
  3. We sort the list of audio-tracks by iso_code.

I'd recommend using iso_code instead of displayName to preserve l10n. Since language names vary by language, but ISO codes are international. (Unless we have the means to localize the display name.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant