Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display selectInstance menu post-installation #89

Open
SethFalco opened this issue Jun 8, 2023 · 1 comment
Open

feat: display selectInstance menu post-installation #89

SethFalco opened this issue Jun 8, 2023 · 1 comment

Comments

@SethFalco
Copy link
Contributor

While working on #42, I noticed something that was worth resolving.

The addon defines a default instance in its settings, invidious.snopyta.org. However, there will eventually come a time that someone installs this extension, and their first experience with it is that everything is broken because the instance is down.

Ideally, they'll understand why and know to go to the settings, but we probably shouldn't assume that. It'd be nice to be as friendly as possible to the uninitiated.

The previous Invidious addon I used by TheAssassin had this problem before in TheAssassin/kodi-invidious-plugin@5474b45.

Some addons like JellyCon display a setup process once installed, for example:

image

Displayed immediately after installation, showing local servers it can find.

I think this extension should do something similar, where after installation, you display the selectInstance menu? You can still keep the default as invidious.snopyta.org in case they close the menu without selecting anything.

The objective being to preserve the initial user-experience when or if invidious.snopyta.org is down, and the default in settings.xml hasn't been updated yet.

@lekma
Copy link
Owner

lekma commented Jun 9, 2023

not a bad idea...let me think about it

lekma added a commit to lekma/script.module.iapc that referenced this issue Jun 13, 2023
lekma added a commit that referenced this issue Jun 13, 2023
lekma added a commit that referenced this issue Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants