Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does/should it work with python <3.8? #75

Open
DJCrashdummy opened this issue Sep 16, 2022 · 1 comment
Open

does/should it work with python <3.8? #75

DJCrashdummy opened this issue Sep 16, 2022 · 1 comment

Comments

@DJCrashdummy
Copy link

beforehand: i wrongly posted this issue already at a different project (TheAssassin/kodi-invidious-plugin#18)... sorry for somehow assuming - just because of the same addon id - that these two projects are closer related.


i'm using the latest OSMC (2022.03-1) which provides Kodi 19.4 and is based on Debian 10 Buster. the addon plugin.video.invidious from the official repo (0.1.0+matrix.1) can be installed, but if i try to send any request to the chosen invidious instance - no mater which one - i get a 403 response.
because it seems a little bit outdated, i activated/installed @lekma's addon repo, installed it's latest version (1.0.10), but then i just get an error notification to look at the logs for further information... the lines invidious related:

2022-09-14 13:54:25.376 T:626      INFO <general>: CAddonMgr::FindAddon: plugin.video.invidious v1.0.10 installed
2022-09-14 13:54:26.178 T:635      INFO <general>: initializing python engine.
2022-09-14 13:54:26.339 T:547   WARNING <general>: CGUIMediaWindow::OnMessage - updating in progress
2022-09-14 13:54:27.424 T:635     ERROR <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                                   Error Type: <class 'SyntaxError'>
                                                   Error Contents: invalid syntax (service.py, line 61)
                                                     File "/home/osmc/.kodi/addons/plugin.video.invidious/lib/service.py", line 61
                                                       if (timeout := getSetting("timeout", float)) <= 0.0:
                                                                   ^
                                                   SyntaxError: invalid syntax
                                                   -->End of Python script error report<--
                                                   
2022-09-14 13:54:28.093 T:635      INFO <general>: Python interpreter stopped
2022-09-14 13:54:34.525 T:547     ERROR <general>: AddonVersion: 0.1.0 matrix.1 is not a valid version
2022-09-14 13:54:57.629 T:547      INFO <general>: Stopping player
2022-09-14 13:54:57.725 T:580      INFO <general>: CZeroconfAvahi::clientCallback: client failure. avahi-daemon stopped? Recreating client...
2022-09-14 13:54:58.353 T:547      INFO <general>: Stopping all
2022-09-14 13:54:58.353 T:547      INFO <general>: ES: Stopping event server
2022-09-14 13:54:58.353 T:547      INFO <general>: stopping zeroconf publishing
2022-09-14 13:54:58.365 T:580      INFO <general>: CZeroconfAvahi::clientCallback: avahi server not available. But may become later...
2022-09-14 13:54:58.377 T:547      INFO <CWebserver[80]>: Stopped
2022-09-14 13:54:58.457 T:581      INFO <general>: ES: UDP Event server stopped
2022-09-14 13:54:58.462 T:547      INFO <general>: stop dvd detect media
2022-09-14 13:54:58.464 T:547      INFO <general>: CServiceAddonManager: failed to stop plugin.video.invidious (may have ended)

it seems that this addon - at least all version in @lekma's addon repo - uses/assumes python 3.8 but Debian Buster provides only python 3.7 (3.7.3-1 in my case to be precise).

if i'm correct, is there any chance to get this addon working with python <3.8 (with reasonable effort)? or is there a way to install the needed dependencies resp. check them beforehand and avoid installing/updating if they are not met?

@SethFalco
Copy link
Contributor

SethFalco commented May 29, 2023

Worth noting that Debian 11 (Bullseye) ships with Python 3.9 already, and Debian 12 (Bookworm) which comes out on June 10th 2023 will ship with Python 3.11.

In May 2022, OSMC announced that they'd release test builds using Debian 11, which should've resolved the issue.

Two days after this issue was made, that version of OSMC got it's official release. 🎉 [source]

If this is the only problem, it looks like it'd be a small change to gain Python 3.7 support for those that are stuck with that for whatever reason. But an alternative solution is to just install a version of OSMC of 2022.09-1 or more recent.

Could be worth closing this. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants