Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Language: Hebrew (Python) #171

Open
7 of 11 tasks
madiedgar opened this issue Oct 29, 2020 · 17 comments
Open
7 of 11 tasks

Review Language: Hebrew (Python) #171

madiedgar opened this issue Oct 29, 2020 · 17 comments

Comments

@madiedgar
Copy link
Member

madiedgar commented Oct 29, 2020

Review Hebrew Translations for Python

In order to review this language to the project, complete the steps detailed in the translation guide (from Step #6 onward). We are primarily working developing Legesher for the Python programming language. In the future we hope to add more programming languages in the future.

Reviewing a translation is extremely important as we want to best understand the culture and context behind the words we select as keywords for the programming languages. The more perspectives the better! 👀Please take your time in being thorough with these translations. Think back when you were learning how to program and how context of words help you bridge together meaning and functionality.

⚠️ Note: this issue is to review the Python keywords and builtin functions only. Any additional translation reviews are encouraged, but not necessary.

To complete this issue:

  • Update any content in this issue from LANGUAGE to the name of the language. (Romanian, Arabic, Welsh etc.)

  • Title this issue "Review Language: Hebrew (Python)"

  • Update the Python section of the Hebrew's locale/__.yml file (files are named using the language abbreviation) by adding comments as followed.

    • Agreeable: Leave a # @username ✅_with any additional commentary afterwards_ after a translation if you agree that the right word to give context to the keyword is the one initially translated.
    • Optimistic: Leave a # @username ❓_with any additional commentary afterwards_ after a translation if you think there may be a better translation / form of the translation
    • Unsure: Leave a # @username 🤔_with any additional commentary afterwards_ after a word that you're not sure if there is a translation

    This issue will be complete when all the words for a programming language looks something like this:

    int: "initiatorsTranslation" # ✅ @firstreviewer, ❓@secondreviewer what about this otherTranslation, ❓@thirdreviewer I agree with otherTranslation, ✅ @fourthreviewer, ✅ @fifthreviewer I also think otherTranslation would be a good option
  • Merge changes into branch titled hebrew-translation on this repo, NOT the master branch. Please reference this issue in the pull request.

Reviewers Needed

In order to add the translations for official use across Legesher, the translations will need to be approved and accepted by 5 additional native / fluent speakers. If you would like to be one of the reviewers for this language, please mention in this issue! 😄 Also feel free to loop in a friend that might be able to help with the translations! Please refer to the translation guide for the next step in the review process.

Review Status:

@Gal-Gilor
Copy link

Hi, I'm a native speaker, and I wish to contribute to this project.

  • Full disclosure: I'm a beginner when it comes to contributing to open-source projects

@madiedgar
Copy link
Member Author

That's wonderful @Gal-Gilor! I've assigned you to this issue. The translation guide should be helpful in understanding the step-by-step process and a great place to start. Please reach out if you need help along the way. 👍🏾

@Gal-Gilor
Copy link

@madiedgar,

I hope the pull request I made is correct.
I added my reviewer comments to the Python section.

I accidentally also added the reviews to the ATOM section.
For now, I left it as is. I assumed someone would need to review that in the future anyway :)

Please let me know if everything is okay.

@michalirak
Copy link

@madiedgar
Hi, also a native speaker and would like to contribute

@madiedgar
Copy link
Member Author

That would be awesome @michalirak ! I'll assign you to this issue, and you can get started. Let me know if you have any questions. 👍🏾

@TomerPacific
Copy link

Hey @madiedgar, looking to help. Is this still relevant?

@madiedgar
Copy link
Member Author

Yes! Would love your help @TomerPacific. Let me know if you have any questions!

@TomerPacific
Copy link

TomerPacific commented Oct 16, 2021

@madiedgar - this issue states to update only the Python section. Would you like me to just go over what was reviewed already and fill in what is missing (Built-In Functions)? Or should I add translations to other languages as well?

@madiedgar
Copy link
Member Author

Great question @TomerPacific 👍 You are correct, this issue is only for Python (keywords and built-in functions). Filling in missing translations in Python's builtin functions would be extremely helpful, in addition to reviewing the Python section.

After you review the Python keywords, I'm more than happy to accept more PR's for other programming languages. Python is the first programming language we are rolling out, so I want to make sure that one is completed first.

@TomerPacific
Copy link

@madiedgar - I have opened a PR. I checked out from the hebrew-translation branch. It seems like it isn't updated with the master branch. Seeing as there are conflicts, would you like me to do this merge?

@madiedgar
Copy link
Member Author

Merged your PR @TomerPacific 👍 Once the Python keywords are officially reviewed for the translation we'll merge it and sync it with master. Your PR was great!

@TomerPacific
Copy link

@madiedgar - glad to be of service. Would you like me to open an issue for another language? What would be your preferred coding language?

@madiedgar
Copy link
Member Author

That would be awesome @TomerPacific 👍 If you'd like to keep reviewing translations, I'd go with Javascript and Atom's editor keywords. After Legesher Python is ready for use, we'll begin working on extending those capabilities to Javascript within Atom's text editor. Feel free to open new issues for both Javascript and Atom. Thank you!

@TomerPacific
Copy link

@madiedgar - I opened an issue For JavaScript

@madiedgar
Copy link
Member Author

Happy October @TomerPacific, @Gal-Gilor, @michalirak, and @Adarwall , thank you for your early support on this project! I'm excited about adding the Hebrew translation to Legesher, but I could use your assistance in gathering enough reviewers. Would you consider reaching out to your friends or peers who share an interest and invite them to join us? 😄 Thank you!

@TomerPacific
Copy link

@madiedgar - How many more reviews are you looking for?

@madiedgar
Copy link
Member Author

@TomerPacific We only need two more reviewers for the Python keywords and builtin functions, so we're very close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment