-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add directional movement between windows #1252
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mautamu
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay in getting to this; this looks good to me! If there aren't any objections, will plan to merge this week.
changing 'dir' to 'direction' to avoid confusion, as dir usually stands for directory
@mautamu I got some time on my hands right now, so I'll go ahead and merge once the checks pass |
hertg
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch introduces directional movement between windows.
This patch introduces a new command:
MoveWindowAt
.The
MoveWindowAt
command can be called with 4 parameters:1
North
: swap the current window with the nearest north window2.
South
: swap the current window with the nearest south window3.
West
: swap the current window with the nearest west window4.
East
: swap the current window with the nearest east windowThose commands allow users to use vim key bindings to move windows around. For example my keybindings for the directional movement are:
(command: MoveWindowAt, value: "North", modifier: ["modkey", "Shift"], key: "k"),
(command: MoveWindowAt, value: "South", modifier: ["modkey", "Shift"], key: "j"),
(command: MoveWindowAt, value: "West", modifier: ["modkey", "Shift"], key: "h"),
(command: MoveWindowAt, value: "East", modifier: ["modkey", "Shift"], key: "l"),
Fixes #1242
Type of change
Updated user documentation:
Please insert user documentation that should be updated (as in the wiki).
See CONTRIBUTING.md User Documentation section for further details.
Note: Manual page changes must be performed in a commit, not in this PR section.
Should be added a new command (MoveWindowAt) in the External Commands section.
Checklist:
make test
locally with no errors or warnings reportedNote: To fully reproduce CI checks, you will need to run
make test-full-nix
. Usually, this is not necessary.