Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Default config.ron file with all the setting commented with explanations about configurations. #1132

Open
thealio opened this issue Aug 25, 2023 · 3 comments
Labels
documentation Improvment on the documentation is needed enhancement Enhancement for an already existing feature good first issue Good for newcomers

Comments

@thealio
Copy link

thealio commented Aug 25, 2023

Describe the enhancement

Hi,
a good, in my opinion essential improvement to leftwm documentation should be to provide a better default config .ron file.
I think that it must include all the available commands and settings, with detailed comments about each command, its function and how to edit settings.

I ask that because, personally, I learn better how to configure things simply studying the configuration files , most of the time.

This should be useful for everyone : having a detailed default config.ron file to study, the user will avoid to ask lots of basilar questions on github , and the devs will consequentially save time .

How important is this enhancement to you?

My workflow is impaired without it

How important do you think is this enhancement for the average LeftWM user?

Their workflow is likely impaired without it

@thealio thealio added the enhancement Enhancement for an already existing feature label Aug 25, 2023
@thealio thealio changed the title [FEATURE REQUEST] Default config.ron file wit all the setting and with cooments with explanations about configurations. [FEATURE REQUEST] Default config.ron file with all the setting commented with explanations about configurations. Aug 25, 2023
@Eskaan
Copy link
Contributor

Eskaan commented Aug 25, 2023

We currently auto-generate the config, that is why there is no explanation given, but I can definitely see the benefits of those comments.
related code | related issue | related wiki page

@VuiMuich is this a #good-first-issue ?

@VuiMuich
Copy link
Member

Tbh, personally I am not a big fan of too verbose commented config files, but we could definitely ship a commented config with the examples. I'll open a PR in a minute to set the foundation for this.

@VuiMuich VuiMuich added good first issue Good for newcomers documentation Improvment on the documentation is needed labels Aug 25, 2023
@VuiMuich
Copy link
Member

With the "Foundation" laid, PRs to comment on the config example in the will be welcom.

In the longrun it would be most useful, if we could dynamically generate the config comments from doc-comments in the code of each config option. I hope this is easily possibly, generally there are a bunch of projects doing very similar things iirc, so the question is "just" how feasible is it to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvment on the documentation is needed enhancement Enhancement for an already existing feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants