Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake needs an owner. #804

Closed
leethomason opened this issue Mar 2, 2020 · 4 comments · Fixed by #851
Closed

CMake needs an owner. #804

leethomason opened this issue Mar 2, 2020 · 4 comments · Fixed by #851
Labels

Comments

@leethomason
Copy link
Owner

Most of the PRs open to TinyXML-2 are CMake related. I've long had no opinion on this - and continue to have no opinion - but we're clearly going back and forth on how this should work. I'm looking for constructive feedback on how to manage this. (That isn't me becoming a CMake expert.)

  • Is there a similar project that has an acceptable CMake that can be user? (Substituting tinyxml-2 as the target, of course)
  • Is TinyXML-2 used in a project that maintains CMakes?
  • Some standard?
    Suggestions?
@Smit-tay
Copy link

Yeah, ummm, this whole CMake thing seems to be a much bigger issue than I realized.

Every other library I try to use just works with CMake find_package. I'm not at all sure why this would be challenging to do for tinyxml2

@maluramichael
Copy link

https://www.youtube.com/watch?v=m0DwB4OvDXk this is a pretty good talk about cmake for library authors.

@leethomason
Copy link
Owner Author

@Smit-tay I don't either. :) But my goal isn't to become a CMake expert. I'm actually hoping someone who really understands CMake and building library can take ownership and make sense of it.

@alexreinking
Copy link
Contributor

@leethomason - I'm the maintainer for the Halide CMake build. Support for the minimum version specified in this project's CMakeLists.txt, 2.6, is about to be completely removed from new versions of CMake so this library will completely stop working for current-version users. Given that most people keep CMake up to date, this will be a problem.

tinyxml2 is, fortunately, very tiny! I would be happy to modernize the CMake build here. I don't think it would take more than a couple days of work. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants