Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Incorrect information in the README file #156

Open
arsdever opened this issue Aug 17, 2022 · 2 comments
Open

[bug] Incorrect information in the README file #156

arsdever opened this issue Aug 17, 2022 · 2 comments
Assignees
Labels

Comments

@arsdever
Copy link

Describe the bug
The README file states the OS64COMBINED flag builds a fat lib including iphoneOS and iphoneOS Simulator, but in the toolchain file the statement is completely different.

To Reproduce

Expected behavior
The documentation is correct

Environment

#    OS64COMBINED = Build for arm64 x86_64 iphoneOS. Combined into FAT STATIC lib (supported on 3.14+ of CMakewith "-G Xcode" argument ONLY)
@arsdever arsdever added the bug label Aug 17, 2022
@arsdever arsdever changed the title [bug] [bug] Incorrect information in the README file Aug 17, 2022
@leetal
Copy link
Owner

leetal commented Aug 18, 2022

This has now been clarified the the ios.toolchain.cmake file as well as that the cmake --install step is necessary. Please respond is OK, and then I'll close this issue.

@arsdever
Copy link
Author

@leetal my main concern is that on the main page, master branch, the information is still incorrect in the README.md. I read there, that the fat lib can be generated via specifying OS64COMBINED, which is not correct.
Screen Shot 2022-08-24 at 14 09 32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants