Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] build config picks up host iconv and fails linking #119

Open
AJenbo opened this issue Dec 1, 2021 · 2 comments
Open

[bug] build config picks up host iconv and fails linking #119

AJenbo opened this issue Dec 1, 2021 · 2 comments
Assignees
Labels

Comments

@AJenbo
Copy link

AJenbo commented Dec 1, 2021

Describe the bug
When building SDL2 the process will fail due to CMake seeing the host system iconv lib, and then failing to find a proper lib to link with at link time.

To Reproduce
Steps to reproduce the behavior:

  1. Clone this PR Build for ios diasurgical/devilutionX#3612
  2. Run the build process

Expected behavior
The build should successfully generate an iOS app.

Environment

@AJenbo AJenbo added the bug label Dec 1, 2021
@leetal
Copy link
Owner

leetal commented Jan 8, 2022

Hi! I see that you merged the aforementioned PR. Did you solve this somehow yourself?

@AJenbo
Copy link
Author

AJenbo commented Jan 8, 2022

we endedup changing libsdl to first check for the ios specific one, and then avoid probing for the host lib if the first check fails. This isn't the most robust solution and only works out because it has another iconv implementation. If there where none and we had to fall back to SDL's own implementation this solution wouldn't have been possible.

https://github.com/libsdl-org/SDL/pull/5046/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants