Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpng fails on OS64 with missing NEON detection option #118

Open
AJenbo opened this issue Dec 1, 2021 · 4 comments
Open

libpng fails on OS64 with missing NEON detection option #118

AJenbo opened this issue Dec 1, 2021 · 4 comments

Comments

@AJenbo
Copy link

AJenbo commented Dec 1, 2021

This might be related to erroneous feature detection

@leetal
Copy link
Owner

leetal commented Jan 8, 2022

Hi! Did you solve this? I saw that the PR mentioned in the other issue had it's version of libPNG upped and I just wonder if that was due to issued in the libPNG buildchain or with this toolchain?

@AJenbo
Copy link
Author

AJenbo commented Jan 8, 2022

we ended up forcing it with a flag

@leetal
Copy link
Owner

leetal commented Jan 8, 2022

Ah okay. So was there an actual issue with this toolchain or libPNG itself? I have actually managed to build libPNG a couple of years ago for iOS and back then, libPNG lacked support for the correct runtime checks of NEON on iOS. Only Android & Linux had implemented runtime checks. Back then, if i recall correctly, specifying -DPNG_ARM_NEON=on was sufficient (since all ARM SoCs since at least armv6 has support for NEON out of the box).

@AJenbo
Copy link
Author

AJenbo commented Jan 8, 2022

Yeah that is the solution we ended up with as well, I wonder if there is a way to detect this automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants