Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New App from Github no longer works #410

Open
jyoost opened this issue Feb 8, 2022 · 8 comments
Open

New App from Github no longer works #410

jyoost opened this issue Feb 8, 2022 · 8 comments
Labels
bug Something isn't working

Comments

@jyoost
Copy link

jyoost commented Feb 8, 2022

Bug report

Describe the bug

Evidently Github changed something and Deploy new app from github no longer works. Just keeps repeating the "set up permissions" screen

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository.

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

System information

  • Version of dokku: latest
  • Version of ledokku: lates

Additional context

Add any other context about the problem here.

@jyoost jyoost added the bug Something isn't working label Feb 8, 2022
@dmo9
Copy link

dmo9 commented Apr 1, 2022

Having the same issue

@JulianBuse
Copy link

Yeah I'm having this problem as well

@djfaizp
Copy link

djfaizp commented Aug 27, 2022

Same issue here

@JustBeYou
Copy link

The bug is caused by a comma being added to GITHUB_APP_CLIENT_SECRET and GITHUB_APP_WEBHOOK_SECRET. You can manually remove it and it will work.

@djfaizp
Copy link

djfaizp commented Sep 4, 2022

Can you please help whare it is ? Can i edit env from my portainer ?

@djfaizp
Copy link

djfaizp commented Sep 4, 2022

The bug is caused by a comma being added to GITHUB_APP_CLIENT_SECRET and GITHUB_APP_WEBHOOK_SECRET. You can manually remove it and it will work.

Can you please share the line of code ?

And example

@JustBeYou
Copy link

@djfaizp, you don't have to patch the code. List ledokku's configuration with dokku config:show ledokku, then you'll see that GITHUB_APP_CLIENT_SECRET and GITHUB_APP_WEBHOOK_SECRET have a comma at the end. Re-set them without the comma, eg. dokku config:set ledokku GITHUB_APP_WEBHOOK_SECRET=<value without comma>.

@djfaizp
Copy link

djfaizp commented Sep 5, 2022

Issue resolved,

Here is solution:-

My app in git has special characters and capital letters That's why it was blocking deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants