Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail to deal with request header Expect: 100-Continue and respone #32

Open
guanglinlv opened this issue Jun 16, 2015 · 2 comments
Open

Comments

@guanglinlv
Copy link

hi @pintsized ,

Bug 1

the following point is case sensitive,so if the value of request header Expect has some upper character,we will make mistake without handle_continue;

Bug 2

_handle_continue only try to read an empty line,but there is some oter optional headers like Date or Content-length. see rfc2616-10.1 Informational 1xx.

Bug 3

http.lua#L557 only handle continue response when Expect: 100-continue request header is there.but as the RFC 2616 say:

- An origin server SHOULD NOT send a 100 (Continue) response if
the request message does not include an Expect request-header
field with the "100-continue" expectation, and MUST NOT send a
100 (Continue) response if such a request comes from an HTTP/1.0
(or earlier) client.

see RFC2616#sec8.2.3.

It's SHOULD NOT requirement,it would be nice if we support it.

I have made a fix and tested it ok.

thanks.

@pavelnemirovsky
Copy link

@guanglinlv hi, can u publish your fix ?

@pintsized
Copy link
Member

Hi, yes I think Bug 1 isn't an issue, but if we're missing some details in _handle_continue please do send a PR with some tests and I'll happily include them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants