Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bifrost.memory.memset segfaults #222

Open
jaycedowell opened this issue Sep 6, 2023 · 1 comment
Open

bifrost.memory.memset segfaults #222

jaycedowell opened this issue Sep 6, 2023 · 1 comment

Comments

@jaycedowell
Copy link
Collaborator

I was running into an issue with the digital system for LWA-NA throwing a segfault when bifrost.memory.memset was called using a bifrost.ndarray that lived in cuda space. I was able to get around it by switching to bifrost.ndarray.memset_array but I did look into the underlying problem. It seems that memset is using a possibly outdated way to determine where the data lives and was always (?) treating the array like it lived in system. I guess there are two things here:

  1. Fix memset to use a better way to determine the memory space.
  2. Do we really need memset if we have memset_array?
@jaycedowell
Copy link
Collaborator Author

According to memory.py it looks like we should just drop memcpy/memcpy2D and memset/memset2D.

# **TODO: Deprecate below here!

jaycedowell added a commit that referenced this issue Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant