-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update python-pdfbox to support PDFBox 3.* #27
Comments
currently a fork of python-pdfbox is available which works smoothly. |
@fakabbir Your fork currently just pins to pdfbox 2.0.28. That is a workaround, not a solution. Apart from that, removing the pdfbox download logic as seen in 613a1a5 isn't nice, better adjust it to download from the v2 release branch only. If offline distributability is desired, you could build a wheel package bundling the jar. |
@fakabbir Also, python-pdfbox main already had a better workaround with #29, so why did you submit #32 after that? See also #32 (comment) |
@mara004 As far as I remember, #29 was not merged or working when I discovered the breaking changes due to pdfbox v3. If #29 is working now, its great and we can discard #32. The other issue is the package looks for the jar during runtime and make it unpredictable and also network depended. To resolve that I create the fork as pdf-box-v2. What I think the best option would be to have the following option
I am not sure @lebedov is still maintaining the project, so as a workaround only for non production high risk environment, python-pdfbox-v2 exisit. Do you have any plans to maintain this repo in future ? |
Thank you, those are all good considerations and I think I'm on the same page. Concerning the python-pdfbox
Agreed. As I hinted at above and in #10, I think it would be best to refactor the code to download pdfbox on setup and also build wheels which bundle pdfbox.
Hmm, yes, looks as if python-pdfbox development might have halted.
Ah, I see. Sorry. Yes, for the purpose of avoiding downloads on runtime, such a fork makes sense as workaround.
Not this repo, but I have a weak ambition to more or less restart from scratch with setup infrastructure and a few API-based helpers. I doubt very much if I have the time, though, and in case I do, I won't be able to put in as much effort as I did for pypdfium2. See also pypdfium2-team/pypdfium2#230 |
The command-line interface to PDFBox was changed in version 3.*.
The text was updated successfully, but these errors were encountered: