Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

Where to store settings for new feature (screenshot location) #46

Open
javl opened this issue Feb 11, 2021 · 2 comments
Open

Where to store settings for new feature (screenshot location) #46

javl opened this issue Feb 11, 2021 · 2 comments

Comments

@javl
Copy link

javl commented Feb 11, 2021

I'm having a problem with the location (and possibly name) of saved screenshots. Currently they are stored inside the MIDItoOBS directory and use the current timestamp + png as their filename.
I'd like to add the option to specify a directory so save in but before I do so wanted to ask what would be the best place to add this value: should I add it to the config.json file, or add it as a startup parameter? (like --screenshotdir, but this gets messy if more variables would get added in the future).

@lebaston100
Copy link
Owner

Hi. If you are thinking about making a PR i'm fine with either.
Startup param would be easiest but adding a new tinydb table called something like "settings" would also work,

@jberentsson
Copy link
Contributor

I can add this to the config file and the command line arguments.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants