Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[app] Public profile fetched from wrong url #377

Closed
friedger opened this issue May 8, 2020 · 5 comments · Fixed by #578
Closed

[app] Public profile fetched from wrong url #377

friedger opened this issue May 8, 2020 · 5 comments · Fixed by #578
Assignees
@hstove
Labels
bug Functionality broken effort:small Expected to take up to 1 day of integration work enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives

Comments

@friedger
Copy link
Contributor

friedger commented May 8, 2020

My public profile is located at

https://gaia.blockstack.org/hub/1Maw8BjWgj6MWrBCfupqQuWANthMhefb2v/0/profile.json

but app fetches it from

https://gaia.blockstack.org/hub/1Maw8BjWgj6MWrBCfupqQuWANthMhefb2v/profile.json

Relevant code:
https://github.com/blockstack/ux/blob/master/packages/keychain/src/identity.ts#L111
@friedger friedger changed the title [app] Public profile fetch from wrong url [app] Public profile fetched from wrong url May 9, 2020
@friedger
Copy link
Contributor Author

friedger commented May 9, 2020 •
edited

Probably related to #354 , #314

@hstove hstove added the bug Functionality broken label May 20, 2020
@ryanarndtcm
Copy link

@timstackblock @hstove can you take a look at this? It is a blocker for using Connect.

@hstove hstove assigned hstove and unassigned timstackblock Jun 10, 2020
@hstove
Copy link
Contributor

hstove commented Jun 10, 2020

Yes - I understand the issue here, and what we need to do to solve it. Let's make sure this gets scheduled for the sprint starting on Monday.

@hstove hstove added this to the UserX 2020 Sprint 2 milestone Jun 17, 2020
hstove added a commit that referenced this issue Jun 29, 2020
@hstove
fix: better lookup for profile location, fixes #377
0ba58f5
hstove added a commit that referenced this issue Jun 29, 2020
@hstove
fix: better lookup for profile location, fixes #377
3d88782
@markmhendrickson
Copy link
Collaborator

@hstove are you taking a new approach to this?

hstove added a commit that referenced this issue Jul 21, 2020
@hstove
fix: better lookup for profile location, fixes #377
638ed2d
hstove added a commit that referenced this issue Jul 21, 2020
@hstove
fix: better lookup for profile location, fixes #377
d002269
hstove added a commit that referenced this issue Jul 21, 2020
@hstove
fix: better lookup for profile location, fixes #377
c5a1a36
hstove added a commit that referenced this issue Jul 21, 2020
@hstove
fix: better lookup for profile location, fixes #377
9fd36e6
hstove added a commit that referenced this issue Jul 21, 2020
@hstove
fix: better lookup for profile location, fixes #377
18e792a
hstove added a commit that referenced this issue Jul 21, 2020
@hstove
fix: better lookup for profile location, fixes #377
31f8018
@hstove hstove closed this as completed in f292cc1 Jul 22, 2020
@friedger
Copy link
Contributor Author

@hstove Could you please reopen it? The profile is written to the wrong location!

This was referenced Jul 26, 2020
Closed
Closed
@markmhendrickson markmhendrickson added this to Ready for design in UserX Sprint (2020 W33-W35) via automation Aug 12, 2020
@markmhendrickson markmhendrickson moved this from Ready for design to Ready for development in UserX Sprint (2020 W33-W35) Aug 12, 2020
@markmhendrickson markmhendrickson removed this from the 2020 W29-W31 milestone Aug 12, 2020
@hstove hstove added enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives effort:small Expected to take up to 1 day of integration work labels Aug 12, 2020
@hstove hstove linked a pull request Aug 19, 2020 that will close this issue
fix: use correct profile URL when uploading profile #578
Merged
@hstove hstove moved this from Ready for development to Code approved in UserX Sprint (2020 W33-W35) Aug 19, 2020
@markmhendrickson markmhendrickson moved this from Code approved to In code review in UserX Sprint (2020 W33-W35) Aug 19, 2020
UserX Sprint (2020 W33-W35) automation moved this from In code review to Done Aug 19, 2020
@friedger friedger mentioned this issue Sep 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hstove hstove

Labels
bug Functionality broken effort:small Expected to take up to 1 day of integration work enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use correct profile URL when uploading profile leather-wallet/extension
5 participants
@markmhendrickson @hstove @friedger @timstackblock @ryanarndtcm