Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username is an empty string, after creating a user with empty name #330

Closed
jorishermans opened this issue Apr 14, 2020 · 9 comments
Closed
Labels
bug Functionality broken

Comments

@jorishermans
Copy link

jorishermans commented Apr 14, 2020

To link my content to a specific user, I need the username of the current loggedin user.

userData = session.loadUserData();
const person = new Person(userData.profile);
const username = userData.username;

This is a show stopper for my application, I need at least the username ...

It will allow me to build up a share link.

My old data from loggin in with blockstack.js is also lost on my localhost session, so I am not sure if the UserSession is working like it should be. The appPrivateKey is also different in both ways.

@jorishermans
Copy link
Author

For me it is not clear how to log in with an already existing user ... I have the secret of that user but I am not able to provide it to login with the same user as with browser.blockstack.org.

I was able to create a user with an empty name ...

@jorishermans jorishermans changed the title username is an empty string Username is an empty string, after creating a user with empty name Apr 14, 2020
@markmhendrickson markmhendrickson added the bug Functionality broken label Apr 15, 2020
@talhasch
Copy link

@markmhx i think this happens due to ip based restriction on username registration endpoint.

@markmhendrickson
Copy link
Collaborator

@hstove is this the same underlying problem as found in #314?

@friedger
Copy link
Contributor

@markmhx This issue is about empty username, #314 is about missing public profile (that is not loaded by default by connect library)

@hstove
Copy link
Contributor

hstove commented Apr 27, 2020

@jorishermans I think I understand the problem, but I'm having a hard time figuring out exactly what is going wrong here. When I re-use an older secret key from the Browser, I am able to use it in the new authenticator, and I get the same usernames and appPrivateKey. Are you using a magic recovery code? Or just the twelve words?

@hstove
Copy link
Contributor

hstove commented Apr 27, 2020

Also, are you really able to just register a username with an empty string? We have validation on this, and if you leave the onboarding flow and come back, you'll still be forced to enter a username. I just tried, and I'm not able to get through the flow without a username. Could you post a video maybe (obviously without the secret key)

@timstackblock
Copy link
Contributor

@markmhx i think this happens due to ip based restriction on username registration endpoint.

@jorishermans can you use a vpn and verify that username creation is not being blocked due to rate limiting IP restrictions

@stale
Copy link

stale bot commented Nov 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 4, 2020
@stale
Copy link

stale bot commented Nov 11, 2020

This issue has been automatically closed. Please reopen if needed.

@stale stale bot closed this as completed Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality broken
Projects
None yet
Development

No branches or pull requests

6 participants