Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how we handle canceling transaction and auth requests #1181

Closed
fbwoolf opened this issue May 19, 2021 · 2 comments
Closed

Refactor how we handle canceling transaction and auth requests #1181

fbwoolf opened this issue May 19, 2021 · 2 comments
Assignees
@kyranjamie
Labels
needs:refactoring Tech debt, developer experience, testing, etc.
Milestone
Pay off technical...

Comments

@fbwoolf
Copy link
Contributor

fbwoolf commented May 19, 2021

Revisit when we refactor messaging. We should just handle the promise correctly so there is an onCancel triggered with the promise rejection in connect.

#1175
hirosystems/connect#122
@markmhendrickson
Copy link
Collaborator

Do we want to tackle this refactor for the completion of #959 specifically or might the refactor extend beyond that issue?

@fbwoolf
Copy link
Contributor Author

fbwoolf commented May 19, 2021

We all discussed circling back to refactor messaging overall so this would be addressed after that. We don't need to complete this for #959.

@aulneau aulneau added this to the Resolve technical debt milestone May 24, 2021
@kyranjamie kyranjamie added the needs:refactoring Tech debt, developer experience, testing, etc. label Jan 7, 2022
kyranjamie added a commit that referenced this issue Aug 11, 2022
@kyranjamie
refactor: better handle window close event, closes #1181
abd553e
kyranjamie added a commit that referenced this issue Aug 11, 2022
@kyranjamie
refactor: better handle window close event, closes #1181
c7aba2c
kyranjamie added a commit that referenced this issue Aug 11, 2022
@kyranjamie
refactor: better handle window close event, closes #1181
b919b66
kyranjamie added a commit that referenced this issue Aug 11, 2022
@kyranjamie
refactor: better handle window close event, closes #1181
b4e97de
@kyranjamie kyranjamie self-assigned this Aug 11, 2022
kyranjamie added a commit that referenced this issue Aug 11, 2022
@kyranjamie
refactor: better handle window close event, closes #1181
2b6ab23
kyranjamie added a commit that referenced this issue Aug 12, 2022
@kyranjamie
refactor: better handle window close event, closes #1181
e48b199
@fbwoolf fbwoolf mentioned this issue Aug 15, 2022
Merged
blockstack-devops pushed a commit that referenced this issue Aug 16, 2022
@semantic-release-bot
chore(release): 3.14.0
c3deacc 
## [3.14.0](v3.13.5...v3.14.0) (2022-08-16)

### Features

* warn when originating tab closes ([552293e](552293e))

### Bug Fixes

* name spoofing detection from metadata ([d9c0e2d](d9c0e2d))
* redirect back after successful unlock ([717ad60](717ad60))
* release notes ([3087cdf](3087cdf))
* semantic release ([3a897b5](3a897b5))
* semantic release add, use yarn ([32a6785](32a6785))
* semantic release package install ([ae59396](ae59396))
* setup and relocate env variables ([e827f2e](e827f2e))
* upgrade semantic-release action plugin ([ea7d747](ea7d747))

### Internal

* <PopupHeader/> component ([4cf384d](4cf384d))
* add conventionalcommits pkg ([728f46d](728f46d))
* add job post ([486eedb](486eedb))
* **atoms:** remove transaction request atom ([ac29a32](ac29a32))
* avoid using localStorage to cache ephemeral values, closes [#2547](#2547) ([4f7126f](4f7126f))
* better handle window close event, closes [#1181](#1181) ([8b6523f](8b6523f))
* coinbase pay ui ([7ede3ce](7ede3ce))
* **deps:** tidy unused packages ([664b59f](664b59f))
* disable sentry ([d88b955](d88b955))
* enable coinbase pay fast checkout ([adcb2c0](adcb2c0))
* fee estimations ([20ef805](20ef805))
* remove more unused packages ([4cab525](4cab525))
* remove react query wrapper ([1e479e5](1e479e5))
* **security:** add dev tools warning ([1021f34](1021f34))
* spell incurred properly ([9fd7ec7](9fd7ec7))
* steps state ([76e8c0a](76e8c0a))
* **tooling:** fix redux devtools ([e42367d](e42367d))
* track on 'disconnected tab' error ([4577b21](4577b21))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyranjamie kyranjamie

Labels
needs:refactoring Tech debt, developer experience, testing, etc.
Projects
None yet
Milestone
Pay off technical debt
Development

No branches or pull requests
4 participants
@markmhendrickson @kyranjamie @fbwoolf @aulneau