Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ability to tab into content within a slide #702

Open
JayBox325 opened this issue Sep 30, 2022 · 5 comments
Open

Disable ability to tab into content within a slide #702

JayBox325 opened this issue Sep 30, 2022 · 5 comments

Comments

@JayBox325
Copy link

Describe the bug
When tabbing through my website, I am finding that I can tab into content that is inside slides that aren't visible. Meaning that I get a weird half and half view when I've tabbed into the button on the next slide.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a page with a slider that has buttons within each slide.
  2. Try to navigate the page with tabbing only.
  3. Notice how the display looks wrong.

Expected behavior
Should only be able to tab into content that is currently visible then use the keyboard nav or the visible pagination to change the slides.

Screenshots
Had to cover a lot of the elements in the image due to NDA, but please note the blue border being around the 'slide selected' element and the red border around the not currently selected slide.

See how the browser has tried to tab into the next slide's button. (although the focus disappeared in the screenshot)
Screenshot 2022-09-30 at 18 40 39

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@stalgiag
Copy link

This problem can also be seen in this official example with Youtube videos. As you continue tabbing you end up controlling videos that aren't in the currently 'selected' slide, causing them to shift over and breaking the interaction. This makes the component inaccessible to keyboard users.

@stale
Copy link

stale bot commented Jun 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 12, 2023
@JayBox325
Copy link
Author

This is still happening and should not be closed.

@stale stale bot removed the wontfix label Jun 13, 2023
Copy link

stale bot commented Dec 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 11, 2023
@JayBox325
Copy link
Author

Poor. This should not be stale. Bump!

@stale stale bot removed the wontfix label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants