Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Melody Playback Any Key Triggers Repeat #134

Open
dj-jayu opened this issue Mar 21, 2023 · 10 comments
Open

Melody Playback Any Key Triggers Repeat #134

dj-jayu opened this issue Mar 21, 2023 · 10 comments

Comments

@dj-jayu
Copy link

dj-jayu commented Mar 21, 2023

I use a Casio Px-750 digital piano as midi input.
In the melody playback mode, any key of the piano I enter triggers a melody repeat, not just the pedals or sliders.
Others parts of the app work normally with my piano.

@leafo
Copy link
Owner

leafo commented Mar 22, 2023

It could be possible that your keyboard is sending a MIDI CC message along with key presses when you press a key. Perhaps a setting of the keyboard?

@dj-jayu
Copy link
Author

dj-jayu commented Mar 22, 2023

Hi, thanks for the answer. I downloaded a midi monitor. This is what is sent to the PC when I press the middle C note.
image

@dj-jayu
Copy link
Author

dj-jayu commented Mar 22, 2023

Every note always comes with the Controller 88 + a different number, before the on and off signals.
image

@dj-jayu
Copy link
Author

dj-jayu commented Mar 22, 2023

Here are the pedal signals:
image

@dj-jayu
Copy link
Author

dj-jayu commented Mar 22, 2023

And here some buttons:
image

@dj-jayu
Copy link
Author

dj-jayu commented Mar 22, 2023

After more research, here's what I've found.
In the Casio Px-750 midi specification available here (https://support.casio.com/storage/en/manual/pdf/EN/008/PX150-1200_AP250-650_MIDI_E_B_EN.pdf):
image

Apparently the Control 88 message is sent every time 'the tone is changed'.

@dj-jayu
Copy link
Author

dj-jayu commented Mar 22, 2023

Apparently the midi specification has changed over the years, and old devices have this issue.
I searched the piano manuals, googled, and asked ChatGPT if there's a way to turn off the Control 88 message, all without success.

So @leafo , if you have no other suggestions, would it be possible to make the 'repeat when pressing any function key on your midi controller' feature optional? As a checkbox?
This would solve the issue for me and possible other users who might also have an older midi controller.

Thanks.

@leafo
Copy link
Owner

leafo commented Mar 22, 2023

Thanks for the extensive testing. I think it's probably best to ignore that type of CC event when checking to replay the melody.

@dj-jayu
Copy link
Author

dj-jayu commented Mar 27, 2023

@leafo , I cloned the repo on my computer, and run 'node install.js'.
But I can't start the application with npm run. I would like to run it locally in order to help with the development and make some tests. If the test are successful, maybe I could contribute to the project.
I know javascript and some react. I don't know moonscript.
Do you have a guide on how should I proceed?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants